disconnect from gconf notifications. Fixes a crash, #563145.

	* libsoup/soup-proxy-resolver-gconf.c (finalize): disconnect from
	gconf notifications. Fixes a crash, #563145.

svn path=/trunk/; revision=1219

diff --git a/ChangeLog b/ChangeLog
index 079e80d..5625efd 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-12-03  Dan Winship  <danw@gnome.org>
+
+       * libsoup/soup-proxy-resolver-gconf.c (finalize): disconnect from
+       gconf notifications. Fixes a crash, #563145.
+
 2008-12-01  Dan Winship  <danw@gnome.org>
 
        * configure.in: 2.25.2

diff --git a/libsoup/soup-proxy-resolver-gconf.c b/libsoup/soup-proxy-resolver-gconf.c
index e43cdff..f3063b2 100644 (file)
--- a/libsoup/soup-proxy-resolver-gconf.c
+++ b/libsoup/soup-proxy-resolver-gconf.c
@@ -76,6 +76,8 @@ finalize (GObject *object)
        SoupProxyResolverGConfPrivate *priv =
                SOUP_PROXY_RESOLVER_GCONF_GET_PRIVATE (object);
 
+       g_signal_handlers_disconnect_by_func (priv->gconf, gconf_value_changed,
+                                             object);
        free_proxy_settings (priv);
        g_object_unref (priv->gconf);
        g_mutex_free (priv->lock);