[media] s5p-mfc: fix video device release double release in probe error path
authorShuah Khan <shuahkh@osg.samsung.com>
Tue, 28 Jun 2016 19:17:16 +0000 (16:17 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 8 Jul 2016 17:26:11 +0000 (14:26 -0300)
Fix Decoder and encoder video device double release in probe error path.
video_device_release(dev->vfd_dec) get called twice if decoder register
fails. Also, video_device_release(dev->vfd_enc) get called twice if encoder
register fails.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/s5p-mfc/s5p_mfc.c

index 6ee620e..274b4f1 100644 (file)
@@ -1266,7 +1266,6 @@ static int s5p_mfc_probe(struct platform_device *pdev)
        ret = video_register_device(dev->vfd_dec, VFL_TYPE_GRABBER, 0);
        if (ret) {
                v4l2_err(&dev->v4l2_dev, "Failed to register video device\n");
-               video_device_release(dev->vfd_dec);
                goto err_dec_reg;
        }
        v4l2_info(&dev->v4l2_dev,
@@ -1275,7 +1274,6 @@ static int s5p_mfc_probe(struct platform_device *pdev)
        ret = video_register_device(dev->vfd_enc, VFL_TYPE_GRABBER, 0);
        if (ret) {
                v4l2_err(&dev->v4l2_dev, "Failed to register video device\n");
-               video_device_release(dev->vfd_enc);
                goto err_enc_reg;
        }
        v4l2_info(&dev->v4l2_dev,