Add input param checkers to JobManagerProxy & JobAction

Change-Id: Id0be6f13b0ba213236c8228f0f099b58e710c28a
Signed-off-by: Mu-Woong Lee <muwoong.lee@samsung.com>

diff --git a/src/client/JobManagerProxy.cpp b/src/client/JobManagerProxy.cpp
index 49edf71d598f9763a40a15c1bfc1d9f4d921b3cb..88ed6d2c77ae307f78175fb40d114f06d93f9cb7 100644 (file)
--- a/src/client/JobManagerProxy.cpp
+++ b/src/client/JobManagerProxy.cpp
@@ -35,6 +35,8 @@ JobManagerProxy::~JobManagerProxy()
 
 int JobManagerProxy::addJob(JobInfo* jobInfo)
 {
+       IF_FAIL_RETURN(jobInfo, E_PARAM);
+
        std::string serialized = jobInfo->serialize();
        GVariant* param = g_variant_new("(s)", serialized.c_str());
        GVariant* result = NULL;
@@ -213,6 +215,8 @@ bool JobManagerProxy::__isAvailable(int type, const std::string& uri)
 
 void JobManagerProxy::__onStartJob(GVariant* param)
 {
+       IF_FAIL_VOID(__startJobCb);
+
        const char* jobStr = NULL;
        gboolean timeout = FALSE;
 
@@ -226,6 +230,8 @@ void JobManagerProxy::__onStartJob(GVariant* param)
 
 void JobManagerProxy::__onStopJob(GVariant* param)
 {
+       IF_FAIL_VOID(__stopJobCb);
+
        const char* jobStr = NULL;
        g_variant_get(param, "(&s)", &jobStr);
 

diff --git a/src/shared/JobAction.cpp b/src/shared/JobAction.cpp
index 902a553601c7148d3e501868ed2e68dd5236fb3c..7e13f75805db2f7fa627191693abcc0332843ba4 100644 (file)
--- a/src/shared/JobAction.cpp
+++ b/src/shared/JobAction.cpp
@@ -71,6 +71,7 @@ JobAction::~JobAction()
 JobAction* JobAction::build(Json::Value& jsonNode)
 {
        Json::Value::Members members = jsonNode.getMemberNames();
+       IF_FAIL_RETURN(!members.empty(), NULL);
 
        if (members[0] == KEY_DBUS) {
                return new JobDBusCall(jsonNode[KEY_DBUS]);