media: samsung: exynos4-is: drop simple-bus from compatibles
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 13 Mar 2023 14:49:09 +0000 (15:49 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 20 Mar 2023 14:28:17 +0000 (15:28 +0100)
The FIMC camera node wrapper is not a bus, so using simple-bus fallback
compatible just to instantiate its children nodes was never correct.
Driver should explicitly populate all its children devices.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/samsung/exynos4-is/media-dev.c

index 22baa42..6839007 100644 (file)
@@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev)
        if (!fmd)
                return -ENOMEM;
 
+       ret = of_platform_populate(dev->of_node, NULL, NULL, dev);
+       if (ret < 0)
+               return -ENOMEM;
+
        spin_lock_init(&fmd->slock);
        INIT_LIST_HEAD(&fmd->pipelines);
        fmd->pdev = pdev;