RDMA/bnxt_re: Use zeroing memory allocator than allocator/memset
authorHimanshu Jha <himanshujha199640@gmail.com>
Sun, 31 Dec 2017 12:32:38 +0000 (18:02 +0530)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 2 Jan 2018 18:20:13 +0000 (11:20 -0700)
Use dma_zalloc_coherent for allocating zeroed
memory and remove unnecessary memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/bnxt_re/qplib_res.c

index 4e10170..ad37d54 100644 (file)
@@ -104,13 +104,12 @@ static int __alloc_pbl(struct pci_dev *pdev, struct bnxt_qplib_pbl *pbl,
 
        if (!sghead) {
                for (i = 0; i < pages; i++) {
-                       pbl->pg_arr[i] = dma_alloc_coherent(&pdev->dev,
-                                                           pbl->pg_size,
-                                                           &pbl->pg_map_arr[i],
-                                                           GFP_KERNEL);
+                       pbl->pg_arr[i] = dma_zalloc_coherent(&pdev->dev,
+                                                            pbl->pg_size,
+                                                            &pbl->pg_map_arr[i],
+                                                            GFP_KERNEL);
                        if (!pbl->pg_arr[i])
                                goto fail;
-                       memset(pbl->pg_arr[i], 0, pbl->pg_size);
                        pbl->pg_count++;
                }
        } else {