re PR fortran/84734 (Compiling codes with insane array dimensions gives an ICE after...

2018-03-09  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/84734
	* arith.c (check_result, eval_intrinsic):  If result overflows, pass
	the expression up the chain instead of a NULL pointer.

2018-03-09  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/84734
	* gfortran.dg/pr84734.f90: New test.

From-SVN: r258416

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 796b58d..d404218 100644 (file)
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,9 @@
+2018-03-10  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+       PR fortran/84734
+       * arith.c (check_result, eval_intrinsic):  If result overflows, pass
+       the expression up the chain instead of a NULL pointer.
+
 2018-03-07  Steven G. Kargl  <kargl@gcc.gnu.org>
 
        PR fortran/64124

diff --git a/gcc/fortran/arith.c b/gcc/fortran/arith.c
index 8f328fe..6f97d0f 100644 (file)
--- a/gcc/fortran/arith.c
+++ b/gcc/fortran/arith.c
@@ -555,10 +555,10 @@ check_result (arith rc, gfc_expr *x, gfc_expr *r, gfc_expr **rp)
       val = ARITH_OK;
     }
 
-  if (val != ARITH_OK)
-    gfc_free_expr (r);
-  else
+  if (val == ARITH_OK || val == ARITH_OVERFLOW)
     *rp = r;
+  else
+    gfc_free_expr (r);
 
   return val;
 }
@@ -1603,9 +1603,13 @@ eval_intrinsic (gfc_intrinsic_op op,
   if (rc != ARITH_OK)
     {
       gfc_error (gfc_arith_error (rc), &op1->where);
+      if (rc == ARITH_OVERFLOW)
+       goto done;
       return NULL;
     }
 
+done:
+
   gfc_free_expr (op1);
   gfc_free_expr (op2);
   return result;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index bf028b8..323e836 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-03-10  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+       PR fortran/84734
+       * gfortran.dg/pr84734.f90: New test.
+
 2018-03-10  Eric Botcazou  <ebotcazou@adacore.com>
 
        * gnat.dg/prot3.adb: New test.

diff --git a/gcc/testsuite/gfortran.dg/pr84734.f90 b/gcc/testsuite/gfortran.dg/pr84734.f90
new file mode 100644 (file)
index 0000000..4b117ae
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr84734.f90
@@ -0,0 +1,4 @@
+! { dg-do compile }
+! PR fortran/84734
+   integer :: b(huge(1_8)+1_8) = 0 ! { dg-error "Arithmetic overflow" }
+   end