v3dv: Initialize time before usage by free_stale_bos.
authorVinson Lee <vlee@freedesktop.org>
Wed, 14 Oct 2020 23:55:12 +0000 (16:55 -0700)
committerMarge Bot <eric+marge@anholt.net>
Fri, 16 Oct 2020 22:34:22 +0000 (22:34 +0000)
Fix defect reported by Coverity Scan.

Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value time.tv_sec when calling free_stale_bos.

Fixes: f78c99f357ee ("v3dv/bo: add a maximum size for the bo_cache and a envvar to configure it")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Alejandro PiƱeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7154>

src/broadcom/vulkan/v3dv_bo.c

index 4b9bb5b..ed82315 100644 (file)
@@ -447,6 +447,7 @@ v3dv_bo_free(struct v3dv_device *device,
 
    if (bo->private &&
        bo->size > cache->max_cache_size - cache->cache_size) {
+      clock_gettime(CLOCK_MONOTONIC, &time);
       mtx_lock(&cache->lock);
       free_stale_bos(device, time.tv_sec);
       mtx_unlock(&cache->lock);