power: supply: Fix refcount leak in rk817_charger_probe
authorQiheng Lin <linqiheng@huawei.com>
Mon, 28 Nov 2022 14:27:40 +0000 (22:27 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:45 +0000 (13:32 +0100)
[ Upstream commit 54c03bfd094fb74f9533a9c28250219afe182382 ]

of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
Reviewed-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/power/supply/rk817_charger.c

index f20a6ac..4f9c1c4 100644 (file)
@@ -1060,8 +1060,10 @@ static int rk817_charger_probe(struct platform_device *pdev)
                return -ENODEV;
 
        charger = devm_kzalloc(&pdev->dev, sizeof(*charger), GFP_KERNEL);
-       if (!charger)
+       if (!charger) {
+               of_node_put(node);
                return -ENOMEM;
+       }
 
        charger->rk808 = rk808;