projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
90b86fc
)
drm: self_refresh: Fix a reversed condition in drm_self_refresh_helper_cleanup()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Wed, 19 Jun 2019 10:01:41 +0000
(13:01 +0300)
committer
Sean Paul
<seanpaul@chromium.org>
Wed, 19 Jun 2019 13:57:16 +0000
(09:57 -0400)
This test is flipped around so it either leads to a memory leak or a
NULL dereference.
Fixes:
1452c25b0e60
("drm: Add helpers to kick off self refresh mode in drivers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link:
https://patchwork.freedesktop.org/patch/msgid/20190619100141.GA28596@mwanda
drivers/gpu/drm/drm_self_refresh_helper.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/drm_self_refresh_helper.c
b/drivers/gpu/drm/drm_self_refresh_helper.c
index
2b3daaf
..
e0d2ad1
100644
(file)
--- a/
drivers/gpu/drm/drm_self_refresh_helper.c
+++ b/
drivers/gpu/drm/drm_self_refresh_helper.c
@@
-205,7
+205,7
@@
void drm_self_refresh_helper_cleanup(struct drm_crtc *crtc)
struct drm_self_refresh_data *sr_data = crtc->self_refresh_data;
/* Helper is already uninitialized */
- if (sr_data)
+ if (
!
sr_data)
return;
crtc->self_refresh_data = NULL;