NFC: nci: Remove redundant assignment to len
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 1 Jun 2021 09:49:50 +0000 (17:49 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Jun 2021 22:52:24 +0000 (15:52 -0700)
Variable 'len' is set to conn_info->max_pkt_payload_len but this
value is never read as it is overwritten with a new value later on,
hence it is a redundant assignment and can be removed.

Clean up the following clang-analyzer warning:

net/nfc/nci/hci.c:164:3: warning: Value stored to 'len' is never read
[clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/nfc/nci/hci.c

index 96865142104f48f71e291f42cee8297bc1471e1c..d6732e5e8958df0bdb6320b67d46fe7e2bb87884 100644 (file)
@@ -161,8 +161,6 @@ static int nci_hci_send_data(struct nci_dev *ndev, u8 pipe,
        *(u8 *)skb_push(skb, 1) = data_type;
 
        do {
-               len = conn_info->max_pkt_payload_len;
-
                /* If last packet add NCI_HFP_NO_CHAINING */
                if (i + conn_info->max_pkt_payload_len -
                    (skb->len + 1) >= data_len) {