btrfs-progs: use switch instead of a series of ifs for output error message
authorZhao Lei <zhaolei@cn.fujitsu.com>
Thu, 6 Aug 2015 03:05:54 +0000 (11:05 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 19 Oct 2015 09:48:24 +0000 (11:48 +0200)
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
cmds-scrub.c

index 3ebda9d..1c3fc03 100644 (file)
@@ -1469,21 +1469,26 @@ static int scrub_start(int argc, char **argv, int resume)
                        ++err;
                        continue;
                }
-               if (sp[i].ret && sp[i].ioctl_errno == ENODEV) {
-                       if (do_print)
-                               fprintf(stderr, "WARNING: device %lld not "
-                                       "present\n", devid);
-                       continue;
-               }
-               if (sp[i].ret && sp[i].ioctl_errno == ECANCELED) {
-                       ++err;
-               } else if (sp[i].ret) {
-                       if (do_print)
-                               fprintf(stderr, "ERROR: scrubbing %s failed "
-                                       "for device id %lld (%s)\n", path,
-                                       devid, strerror(sp[i].ioctl_errno));
-                       ++err;
-                       continue;
+               if (sp[i].ret) {
+                       switch (sp[i].ioctl_errno) {
+                       case ENODEV:
+                               if (do_print)
+                                       fprintf(stderr,
+                                           "WARNING: device %lld not present\n",
+                                           devid);
+                               continue;
+                       case ECANCELED:
+                               ++err;
+                               break;
+                       default:
+                               if (do_print)
+                                       fprintf(stderr,
+                       "ERROR: scrubbing %s failed for device id %lld (%s)\n",
+                                               path, devid,
+                                               strerror(sp[i].ioctl_errno));
+                               ++err;
+                               continue;
+                       }
                }
                if (sp[i].scrub_args.progress.uncorrectable_errors > 0)
                        e_uncorrectable++;