c-parser.c (c_parser_translation_unit): Diagnose declare target without corresponding...

	* c-parser.c (c_parser_translation_unit): Diagnose declare target
	without corresponding end declare target.

	* semantics.c (finish_translation_unit): Diagnose declare target
	without corresponding end declare target.

	* c-c++-common/gomp/declare-target-5.c: New test.

From-SVN: r278065

diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog
index 8cea3f5..e3a5120 100644 (file)
--- a/gcc/c/ChangeLog
+++ b/gcc/c/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-11  Jakub Jelinek  <jakub@redhat.com>
+
+       * c-parser.c (c_parser_translation_unit): Diagnose declare target
+       without corresponding end declare target.
+
 2019-11-08  Richard Sandiford  <richard.sandiford@arm.com>
 
        * c-convert.c (convert): Only handle vector conversions if one of

diff --git a/gcc/c/c-parser.c b/gcc/c/c-parser.c
index ed6a9dd..12deb3e 100644 (file)
--- a/gcc/c/c-parser.c
+++ b/gcc/c/c-parser.c
@@ -1554,6 +1554,14 @@ c_parser_translation_unit (c_parser *parser)
   FOR_EACH_VEC_ELT (incomplete_record_decls, i, decl)
     if (DECL_SIZE (decl) == NULL_TREE && TREE_TYPE (decl) != error_mark_node)
       error ("storage size of %q+D isn%'t known", decl);
+
+  if (current_omp_declare_target_attribute)
+    {
+      if (!errorcount)
+        error ("%<#pragma omp declare target%> without corresponding "
+              "%<#pragma omp end declare target%>");
+      current_omp_declare_target_attribute = 0;
+    }
 }
 
 /* Parse an external declaration (C90 6.7, C99 6.9, C11 6.9).

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 23576ec..81811a4 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-11  Jakub Jelinek  <jakub@redhat.com>
+
+       * semantics.c (finish_translation_unit): Diagnose declare target
+       without corresponding end declare target.
+
 2019-11-10  Jason Merrill  <jason@redhat.com>
 
        Implement D1957R0, T* to bool should be considered narrowing.

diff --git a/gcc/cp/semantics.c b/gcc/cp/semantics.c
index 8293c07..0ce73af 100644 (file)
--- a/gcc/cp/semantics.c
+++ b/gcc/cp/semantics.c
@@ -3048,6 +3048,14 @@ finish_translation_unit (void)
 
   /* Do file scope __FUNCTION__ et al.  */
   finish_fname_decls ();
+
+  if (scope_chain->omp_declare_target_attribute)
+    {
+      if (!errorcount)
+       error ("%<#pragma omp declare target%> without corresponding "
+              "%<#pragma omp end declare target%>");
+      scope_chain->omp_declare_target_attribute = 0;
+    }
 }
 
 /* Finish a template type parameter, specified as AGGR IDENTIFIER.

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 88088fa..138afb2 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-11-11  Jakub Jelinek  <jakub@redhat.com>
+
+       * c-c++-common/gomp/declare-target-5.c: New test.
+
 2019-11-11  Richard Sandiford  <richard.sandiford@arm.com>
 
        * gcc.dg/vect/pr92420.c: New test.

diff --git a/gcc/testsuite/c-c++-common/gomp/declare-target-5.c b/gcc/testsuite/c-c++-common/gomp/declare-target-5.c
new file mode 100644 (file)
index 0000000..b52c9f2
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/gomp/declare-target-5.c
@@ -0,0 +1,2 @@
+#pragma omp declare target
+void foo (void);       /* { dg-error "'#pragma omp declare target' without corresponding '#pragma omp end declare target'" } */