mwifiex: don't pretend to resume while remove()'ing
authorBrian Norris <briannorris@chromium.org>
Fri, 18 Nov 2016 14:00:28 +0000 (19:30 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 19 Nov 2016 07:18:49 +0000 (09:18 +0200)
The device core will not allow suspend() to race with remove().

Signed-off-by: Brian Norris <briannorris@chromium.org>
Tested-by: Xinming Hu <huxm@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/marvell/mwifiex/pcie.c
drivers/net/wireless/marvell/mwifiex/sdio.c
drivers/net/wireless/marvell/mwifiex/usb.c

index 86ae084..cecf1a0 100644 (file)
@@ -251,11 +251,6 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev)
                return;
 
        if (user_rmmod && !adapter->mfg_mode) {
-#ifdef CONFIG_PM_SLEEP
-               if (adapter->is_suspended)
-                       mwifiex_pcie_resume(&pdev->dev);
-#endif
-
                mwifiex_deauthenticate_all(adapter);
 
                priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
index 5312ffb..2f5b01f 100644 (file)
@@ -244,9 +244,6 @@ mwifiex_sdio_remove(struct sdio_func *func)
        mwifiex_dbg(adapter, INFO, "info: SDIO func num=%d\n", func->num);
 
        if (user_rmmod && !adapter->mfg_mode) {
-               if (adapter->is_suspended)
-                       mwifiex_sdio_resume(adapter->dev);
-
                mwifiex_deauthenticate_all(adapter);
 
                priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
index 63a755c..45c9430 100644 (file)
@@ -614,11 +614,6 @@ static void mwifiex_usb_disconnect(struct usb_interface *intf)
                return;
 
        if (user_rmmod && !adapter->mfg_mode) {
-#ifdef CONFIG_PM
-               if (adapter->is_suspended)
-                       mwifiex_usb_resume(intf);
-#endif
-
                mwifiex_deauthenticate_all(adapter);
 
                mwifiex_init_shutdown_fw(mwifiex_get_priv(adapter,