media: usb: as102: drop as102_dev NULL check
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 24 May 2023 12:11:45 +0000 (13:11 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 9 Jun 2023 15:07:30 +0000 (16:07 +0100)
Fixes this smatch warning:

drivers/media/usb/as102/as102_usb_drv.c:306 as102_usb_release() warn: can 'as102_dev' even be NULL?

And indeed, as102_dev can never be NULL, so just drop the NULL check.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/usb/as102/as102_usb_drv.c

index 50419e8..6b38014 100644 (file)
@@ -303,10 +303,8 @@ static void as102_usb_release(struct kref *kref)
        struct as102_dev_t *as102_dev;
 
        as102_dev = container_of(kref, struct as102_dev_t, kref);
-       if (as102_dev != NULL) {
-               usb_put_dev(as102_dev->bus_adap.usb_dev);
-               kfree(as102_dev);
-       }
+       usb_put_dev(as102_dev->bus_adap.usb_dev);
+       kfree(as102_dev);
 }
 
 static void as102_usb_disconnect(struct usb_interface *intf)