Correct the argument list of command `breakpoint read`
authorGongyu Deng <gy_deng@icloud.com>
Fri, 15 May 2020 06:34:24 +0000 (08:34 +0200)
committerRaphael Isemann <teemperor@gmail.com>
Fri, 15 May 2020 07:00:05 +0000 (09:00 +0200)
Summary: Command `breakpoint read` should not accept breakpoint ids as
arguments, and in fact, it is not implemented to deal with breakpoint id
arguments either. So this patch is to correct the argument list of this
command so that the help text won't misguide users.

Reviewers: teemperor, JDevlieghere, jingham

Reviewed By: teemperor, JDevlieghere

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D79722

lldb/source/Commands/CommandObjectBreakpoint.cpp

index fbd96c2..be7ef8a 100644 (file)
@@ -2034,14 +2034,7 @@ public:
                             "Read and set the breakpoints previously saved to "
                             "a file with \"breakpoint write\".  ",
                             nullptr),
-        m_options() {
-    CommandArgumentEntry arg;
-    CommandObject::AddIDsArgumentData(arg, eArgTypeBreakpointID,
-                                      eArgTypeBreakpointIDRange);
-    // Add the entry for the first argument for this command to the object's
-    // arguments vector.
-    m_arguments.push_back(arg);
-  }
+        m_options() {}
 
   ~CommandObjectBreakpointRead() override = default;