surface: surface3_power: Drop redundant acpi_bus_get_device() call
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 13 Oct 2021 16:12:31 +0000 (18:12 +0200)
committerHans de Goede <hdegoede@redhat.com>
Tue, 19 Oct 2021 14:55:53 +0000 (16:55 +0200)
If the ACPI companion of a given device is not present, the result
of the ACPI_HANDLE() evaluation for it will be NULL, so calling
acpi_bus_get_device() on ACPI_HANDLE() result in order to validate
it is redundant.

Drop the redundant acpi_bus_get_device() call from mshw0011_notify()
along with a local variable related to it.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/3160001.aeNJFYEL58@kreacher
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/surface/surface3_power.c

index 90c1568..abac3ee 100644 (file)
@@ -159,12 +159,11 @@ mshw0011_notify(struct mshw0011_data *cdata, u8 arg1, u8 arg2,
                unsigned int *ret_value)
 {
        union acpi_object *obj;
-       struct acpi_device *adev;
        acpi_handle handle;
        unsigned int i;
 
        handle = ACPI_HANDLE(&cdata->adp1->dev);
-       if (!handle || acpi_bus_get_device(handle, &adev))
+       if (!handle)
                return -ENODEV;
 
        obj = acpi_evaluate_dsm_typed(handle, &mshw0011_guid, arg1, arg2, NULL,