arm64: dts: clearfog-gt-8k: fix switch link configuration
authorRussell King <rmk+kernel@armlinux.org.uk>
Sun, 19 Jul 2020 11:00:40 +0000 (12:00 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Jul 2020 01:11:10 +0000 (18:11 -0700)
The commit below caused a regression for clearfog-gt-8k, where the link
between the switch and the host does not come up.

Investigation revealed two issues:
- MV88E6xxx DSA no longer allows an in-band link to come up as the link
  is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix
  in-band AN link establishment" addresses this.

- The dts configured dissimilar link modes at each end of the host to
  switch link; the host was configured using a fixed link (so has no
  in-band status) and the switch was configured to expect in-band
  status.

With both issues fixed, the regression is resolved.

Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")
Reported-by: Martin Rowe <martin.p.rowe@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts

index c8243da..eb01cc9 100644 (file)
        status = "okay";
        phy-mode = "2500base-x";
        phys = <&cp1_comphy5 2>;
-       fixed-link {
-               speed = <2500>;
-               full-duplex;
-       };
+       managed = "in-band-status";
 };
 
 &cp1_spi1 {