genetlink: move the private fields in struct genl_family
authorJakub Kicinski <kuba@kernel.org>
Fri, 4 Nov 2022 19:13:32 +0000 (12:13 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Nov 2022 12:30:16 +0000 (12:30 +0000)
Move the private fields down to form a "private section".
Use the kdoc "private:" label comment thing to hide them
from the main kdoc comment.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/genetlink.h

index 9f97f73..81180fc 100644 (file)
@@ -23,7 +23,6 @@ struct genl_info;
 
 /**
  * struct genl_family - generic netlink family
- * @id: protocol family identifier (private)
  * @hdrsize: length of user specific header in bytes
  * @name: name of family
  * @version: protocol version
@@ -43,8 +42,6 @@ struct genl_info;
  * @resv_start_op: first operation for which reserved fields of the header
  *     can be validated and policies are required (see below);
  *     new families should leave this field at zero
- * @mcgrp_offset: starting number of multicast group IDs in this family
- *     (private)
  * @ops: the operations supported by this family
  * @n_ops: number of operations supported by this family
  * @small_ops: the small-struct operations supported by this family
@@ -58,12 +55,10 @@ struct genl_info;
  * if policy is not provided core will reject all TLV attributes.
  */
 struct genl_family {
-       int                     id;             /* private */
        unsigned int            hdrsize;
        char                    name[GENL_NAMSIZ];
        unsigned int            version;
        unsigned int            maxattr;
-       unsigned int            mcgrp_offset;   /* private */
        u8                      netnsok:1;
        u8                      parallel_ops:1;
        u8                      n_ops;
@@ -81,6 +76,12 @@ struct genl_family {
        const struct genl_small_ops *small_ops;
        const struct genl_multicast_group *mcgrps;
        struct module           *module;
+
+/* private: internal use only */
+       /* protocol family identifier */
+       int                     id;
+       /* starting number of multicast group IDs in this family */
+       unsigned int            mcgrp_offset;
 };
 
 /**