projects
/
platform
/
upstream
/
systemd.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
459500a
)
pid1: remove unnecessary error reassignment
author
Zbigniew Jędrzejewski-Szmek
<zbyszek@in.waw.pl>
Tue, 2 Oct 2018 10:35:37 +0000
(12:35 +0200)
committer
Zbigniew Jędrzejewski-Szmek
<zbyszek@in.waw.pl>
Tue, 2 Oct 2018 13:36:24 +0000
(15:36 +0200)
LGTM was complaining:
> Comparison is always true because r >= 0.
src/core/manager.c
patch
|
blob
|
history
diff --git
a/src/core/manager.c
b/src/core/manager.c
index
5baa30d
..
c361a1e
100644
(file)
--- a/
src/core/manager.c
+++ b/
src/core/manager.c
@@
-3459,9
+3459,7
@@
int manager_reload(Manager *m) {
m->uid_refs = hashmap_free(m->uid_refs);
m->gid_refs = hashmap_free(m->gid_refs);
- q = lookup_paths_init(&m->lookup_paths, m->unit_file_scope, 0, NULL);
- if (q < 0 && r >= 0)
- r = q;
+ r = lookup_paths_init(&m->lookup_paths, m->unit_file_scope, 0, NULL);
q = manager_run_environment_generators(m);
if (q < 0 && r >= 0)