afs: afs_vnode_commit_status() doesn't need to check the RPC error
authorDavid Howells <dhowells@redhat.com>
Mon, 15 Jun 2020 23:52:30 +0000 (00:52 +0100)
committerDavid Howells <dhowells@redhat.com>
Tue, 16 Jun 2020 15:26:57 +0000 (16:26 +0100)
afs_vnode_commit_status() is only ever called if op->error is 0, so remove
the op->error checks from the function.

Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept")
Signed-off-by: David Howells <dhowells@redhat.com>
fs/afs/inode.c

index 56e60d5..d5d0ae7 100644 (file)
@@ -281,8 +281,6 @@ void afs_vnode_commit_status(struct afs_operation *op, struct afs_vnode_param *v
 
        _enter("");
 
-       ASSERTCMP(op->error, ==, 0);
-
        write_seqlock(&vnode->cb_lock);
 
        if (vp->scb.have_error) {
@@ -300,7 +298,7 @@ void afs_vnode_commit_status(struct afs_operation *op, struct afs_vnode_param *v
 
        write_sequnlock(&vnode->cb_lock);
 
-       if (op->error == 0 && vp->scb.have_status)
+       if (vp->scb.have_status)
                afs_cache_permit(vnode, op->key, vp->cb_break_before, &vp->scb);
 }