scsi: hisi_sas: Modify return type of debugfs functions

For functions which always return 0, which is never checked, make to return
void.

Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index a225570..be15280 100644 (file)
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -2956,8 +2956,8 @@ static const struct file_operations hisi_sas_debugfs_port_fops = {
        .owner = THIS_MODULE,
 };
 
-static int hisi_sas_show_row_64(struct seq_file *s, int index,
-                               int sz, __le64 *ptr)
+static void hisi_sas_show_row_64(struct seq_file *s, int index,
+                                int sz, __le64 *ptr)
 {
        int i;
 
@@ -2970,12 +2970,10 @@ static int hisi_sas_show_row_64(struct seq_file *s, int index,
        }
 
        seq_puts(s, "\n");
-
-       return 0;
 }
 
-static int hisi_sas_show_row_32(struct seq_file *s, int index,
-                               int sz, __le32 *ptr)
+static void hisi_sas_show_row_32(struct seq_file *s, int index,
+                                int sz, __le32 *ptr)
 {
        int i;
 
@@ -2987,11 +2985,9 @@ static int hisi_sas_show_row_32(struct seq_file *s, int index,
                        seq_puts(s, "\n\t");
        }
        seq_puts(s, "\n");
-
-       return 0;
 }
 
-static int hisi_sas_cq_show_slot(struct seq_file *s, int slot, void *cq_ptr)
+static void hisi_sas_cq_show_slot(struct seq_file *s, int slot, void *cq_ptr)
 {
        struct hisi_sas_cq *cq = cq_ptr;
        struct hisi_hba *hisi_hba = cq->hisi_hba;
@@ -2999,20 +2995,18 @@ static int hisi_sas_cq_show_slot(struct seq_file *s, int slot, void *cq_ptr)
        __le32 *complete_hdr = complete_queue +
                        (hisi_hba->hw->complete_hdr_size * slot);
 
-       return hisi_sas_show_row_32(s, slot,
-                               hisi_hba->hw->complete_hdr_size,
-                               complete_hdr);
+       hisi_sas_show_row_32(s, slot,
+                            hisi_hba->hw->complete_hdr_size,
+                            complete_hdr);
 }
 
 static int hisi_sas_debugfs_cq_show(struct seq_file *s, void *p)
 {
        struct hisi_sas_cq *cq = s->private;
-       int slot, ret;
+       int slot;
 
        for (slot = 0; slot < HISI_SAS_QUEUE_SLOTS; slot++) {
-               ret = hisi_sas_cq_show_slot(s, slot, cq);
-               if (ret)
-                       return ret;
+               hisi_sas_cq_show_slot(s, slot, cq);
        }
        return 0;
 }
@@ -3030,7 +3024,7 @@ static const struct file_operations hisi_sas_debugfs_cq_fops = {
        .owner = THIS_MODULE,
 };
 
-static int hisi_sas_dq_show_slot(struct seq_file *s, int slot, void *dq_ptr)
+static void hisi_sas_dq_show_slot(struct seq_file *s, int slot, void *dq_ptr)
 {
        struct hisi_sas_dq *dq = dq_ptr;
        struct hisi_hba *hisi_hba = dq->hisi_hba;
@@ -3038,18 +3032,15 @@ static int hisi_sas_dq_show_slot(struct seq_file *s, int slot, void *dq_ptr)
        __le32 *cmd_hdr = cmd_queue +
                sizeof(struct hisi_sas_cmd_hdr) * slot;
 
-       return hisi_sas_show_row_32(s, slot, sizeof(struct hisi_sas_cmd_hdr),
-                                   cmd_hdr);
+       hisi_sas_show_row_32(s, slot, sizeof(struct hisi_sas_cmd_hdr), cmd_hdr);
 }
 
 static int hisi_sas_debugfs_dq_show(struct seq_file *s, void *p)
 {
-       int slot, ret;
+       int slot;
 
        for (slot = 0; slot < HISI_SAS_QUEUE_SLOTS; slot++) {
-               ret = hisi_sas_dq_show_slot(s, slot, s->private);
-               if (ret)
-                       return ret;
+               hisi_sas_dq_show_slot(s, slot, s->private);
        }
        return 0;
 }
@@ -3071,15 +3062,12 @@ static int hisi_sas_debugfs_iost_show(struct seq_file *s, void *p)
 {
        struct hisi_hba *hisi_hba = s->private;
        struct hisi_sas_iost *debugfs_iost = hisi_hba->debugfs_iost;
-       int i, ret, max_command_entries = HISI_SAS_MAX_COMMANDS;
+       int i, max_command_entries = HISI_SAS_MAX_COMMANDS;
 
        for (i = 0; i < max_command_entries; i++, debugfs_iost++) {
                __le64 *iost = &debugfs_iost->qw0;
 
-               ret = hisi_sas_show_row_64(s, i, sizeof(*debugfs_iost),
-                                          iost);
-               if (ret)
-                       return ret;
+               hisi_sas_show_row_64(s, i, sizeof(*debugfs_iost), iost);
        }
 
        return 0;
@@ -3140,17 +3128,14 @@ static const struct file_operations hisi_sas_debugfs_iost_cache_fops = {
 
 static int hisi_sas_debugfs_itct_show(struct seq_file *s, void *p)
 {
-       int i, ret;
+       int i;
        struct hisi_hba *hisi_hba = s->private;
        struct hisi_sas_itct *debugfs_itct = hisi_hba->debugfs_itct;
 
        for (i = 0; i < HISI_SAS_MAX_ITCT_ENTRIES; i++, debugfs_itct++) {
                __le64 *itct = &debugfs_itct->qw0;
 
-               ret = hisi_sas_show_row_64(s, i, sizeof(*debugfs_itct),
-                                          itct);
-               if (ret)
-                       return ret;
+               hisi_sas_show_row_64(s, i, sizeof(*debugfs_itct), itct);
        }
 
        return 0;