usb: musb: core: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 27 Sep 2022 07:26:12 +0000 (15:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Sep 2022 08:36:06 +0000 (10:36 +0200)
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220927072616.913672-2-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/musb_core.c

index bbbcfd4..03027c6 100644 (file)
@@ -2595,9 +2595,7 @@ fail2:
        musb_platform_exit(musb);
 
 fail1:
-       if (status != -EPROBE_DEFER)
-               dev_err(musb->controller,
-                       "%s failed with status %d\n", __func__, status);
+       dev_err_probe(musb->controller, status, "%s failed\n", __func__);
 
        musb_free(musb);