net: phy: remove gen10g_no_soft_reset
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 2 Mar 2019 16:13:11 +0000 (17:13 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Mar 2019 05:47:57 +0000 (21:47 -0800)
genphy_no_soft_reset and gen10g_no_soft_reset are both the same no-ops,
one is enough.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/cortina.c
drivers/net/phy/marvell10g.c
drivers/net/phy/phy-c45.c
drivers/net/phy/teranetics.c
include/linux/phy.h

index a64eb21..856cdc3 100644 (file)
@@ -82,7 +82,7 @@ static struct phy_driver cortina_driver[] = {
        .features       = PHY_10GBIT_FEATURES,
        .config_aneg    = gen10g_config_aneg,
        .read_status    = cortina_read_status,
-       .soft_reset     = gen10g_no_soft_reset,
+       .soft_reset     = genphy_no_soft_reset,
        .probe          = cortina_probe,
 },
 };
index 79106e7..100b401 100644 (file)
@@ -459,7 +459,7 @@ static struct phy_driver mv3310_drivers[] = {
                .phy_id_mask    = MARVELL_PHY_ID_MASK,
                .name           = "mv88x3310",
                .get_features   = mv3310_get_features,
-               .soft_reset     = gen10g_no_soft_reset,
+               .soft_reset     = genphy_no_soft_reset,
                .config_init    = mv3310_config_init,
                .probe          = mv3310_probe,
                .suspend        = mv3310_suspend,
@@ -474,7 +474,7 @@ static struct phy_driver mv3310_drivers[] = {
                .name           = "mv88x2110",
                .get_features   = genphy_c45_pma_read_abilities,
                .probe          = mv3310_probe,
-               .soft_reset     = gen10g_no_soft_reset,
+               .soft_reset     = genphy_no_soft_reset,
                .config_init    = mv3310_config_init,
                .config_aneg    = mv3310_config_aneg,
                .aneg_done      = mv3310_aneg_done,
index 6cd4bd5..c596eb5 100644 (file)
@@ -508,18 +508,11 @@ static int gen10g_read_status(struct phy_device *phydev)
        return genphy_c45_read_link(phydev);
 }
 
-int gen10g_no_soft_reset(struct phy_device *phydev)
-{
-       /* Do nothing for now */
-       return 0;
-}
-EXPORT_SYMBOL_GPL(gen10g_no_soft_reset);
-
 struct phy_driver genphy_10g_driver = {
        .phy_id         = 0xffffffff,
        .phy_id_mask    = 0xffffffff,
        .name           = "Generic 10G PHY",
-       .soft_reset     = gen10g_no_soft_reset,
+       .soft_reset     = genphy_no_soft_reset,
        .features       = PHY_10GBIT_FEATURES,
        .config_aneg    = gen10g_config_aneg,
        .read_status    = gen10g_read_status,
index 9528021..beb054b 100644 (file)
@@ -78,7 +78,7 @@ static struct phy_driver teranetics_driver[] = {
        .phy_id_mask    = 0xffffffff,
        .name           = "Teranetics TN2020",
        .features       = PHY_10GBIT_FEATURES,
-       .soft_reset     = gen10g_no_soft_reset,
+       .soft_reset     = genphy_no_soft_reset,
        .aneg_done      = teranetics_aneg_done,
        .config_aneg    = gen10g_config_aneg,
        .read_status    = teranetics_read_status,
index 6079424..3408489 100644 (file)
@@ -1119,7 +1119,6 @@ int genphy_c45_read_status(struct phy_device *phydev);
 
 /* The gen10g_* functions are the old Clause 45 stub */
 int gen10g_config_aneg(struct phy_device *phydev);
-int gen10g_no_soft_reset(struct phy_device *phydev);
 
 static inline int phy_read_status(struct phy_device *phydev)
 {