qlcnic: silence false positive overflow warning
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 30 Jan 2013 22:14:10 +0000 (22:14 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 3 Feb 2013 04:00:22 +0000 (23:00 -0500)
We actually store the MAC address as well as the board_name here.  The
longest board_name is 75 characters so there is more than enough room
to hold the 17 character MAC and the ": " divider.  But making this
buffer larger silences a static checker warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

index f3deef0..6a59a11 100644 (file)
@@ -1813,7 +1813,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        struct qlcnic_hardware_context *ahw;
        int err, pci_using_dac = -1;
        u32 capab2;
-       char board_name[QLCNIC_MAX_BOARD_NAME_LEN];
+       char board_name[QLCNIC_MAX_BOARD_NAME_LEN + 19]; /* MAC + ": " + name */
 
        err = pci_enable_device(pdev);
        if (err)