projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5f12550
)
usb: typec: tipd: Cleanup resources if devm_tps6598_psy_register fails
author
Sven Peter
<sven@svenpeter.dev>
Mon, 14 Nov 2022 17:44:46 +0000
(18:44 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:39 +0000
(13:32 +0100)
[ Upstream commit
19c220e9ab00f50edefb9667e3101e84a5112df2
]
We can't just return if devm_tps6598_psy_register fails since previous
resources are not devres managed and have yet to be cleaned up.
Fixes:
10eb0b6ac63a
("usb: typec: tps6598x: Export some power supply properties")
Signed-off-by: Sven Peter <sven@svenpeter.dev>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link:
https://lore.kernel.org/r/20221114174449.34634-1-sven@svenpeter.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/typec/tipd/core.c
patch
|
blob
|
history
diff --git
a/drivers/usb/typec/tipd/core.c
b/drivers/usb/typec/tipd/core.c
index
2a77bab
..
83a7a82
100644
(file)
--- a/
drivers/usb/typec/tipd/core.c
+++ b/
drivers/usb/typec/tipd/core.c
@@
-814,7
+814,7
@@
static int tps6598x_probe(struct i2c_client *client)
ret = devm_tps6598_psy_register(tps);
if (ret)
-
return re
t;
+
goto err_role_pu
t;
tps->port = typec_register_port(&client->dev, &typec_cap);
if (IS_ERR(tps->port)) {