ASoC: qcom: fix unmet direct dependencies for SND_SOC_QDSP6
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Fri, 30 Sep 2022 10:53:47 +0000 (11:53 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 30 Sep 2022 11:03:12 +0000 (12:03 +0100)
SND_SOC_QDSP6 already has COMPILE_TEST so remove that from
SND_SOC_SC8280XP and also add QCOM_APR dependencies to
SND_SOC_SC8280XP like other Qualcomm machine drivers.

This should also fix below warning:
on x86_64, when QCOM_APR is not set and COMPILE_TEST=y:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y]
&& SND_SOC_QCOM [=y] && QCOM_APR [=n] && COMMON_CLK [=y]
  Selected by [y]:
  - SND_SOC_SC8280XP [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y]
&& SND_SOC_QCOM [=y] && (QCOM_APR [=n] || COMPILE_TEST [=y]) &&
 SOUNDWIRE [=y] && COMMON_CLK [=y]

Fixes: 295aeea6646a ("ASoC: qcom: add machine driver for sc8280xp")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220930105347.41127-1-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/Kconfig

index 1b0252e..d0e59e0 100644 (file)
@@ -175,8 +175,7 @@ config SND_SOC_SM8250
 
 config SND_SOC_SC8280XP
        tristate "SoC Machine driver for SC8280XP boards"
-       depends on QCOM_APR || COMPILE_TEST
-       depends on SOUNDWIRE
+       depends on QCOM_APR && SOUNDWIRE
        depends on COMMON_CLK
        select SND_SOC_QDSP6
        select SND_SOC_QCOM_COMMON