Refactor the samevalue internal method and add tests for this method.

Noticing that the only difference between samevalue and strict equality is on
numbers we can simplify SameValue.

The old version did not return a correct answer if called on two strings since
StringEquals (from runtime.cc) returns an answer that is the negated value
(if treated as a boolean).

Review URL: http://codereview.chromium.org/2136024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4713 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/runtime.js b/src/runtime.js
index 887436a..3e4d473 100644 (file)
--- a/src/runtime.js
+++ b/src/runtime.js
@@ -559,19 +559,15 @@ function ToInt32(x) {
 // ES5, section 9.12
 function SameValue(x, y) {
   if (typeof x != typeof y) return false;
-  if (IS_NULL_OR_UNDEFINED(x)) return true;
   if (IS_NUMBER(x)) {
     if (NUMBER_IS_NAN(x) && NUMBER_IS_NAN(y)) return true;
     // x is +0 and y is -0 or vice versa.
     if (x === 0 && y === 0 && (1 / x) != (1 / y)) {
       return false;
     }
-    return x == y;
+    return x === y;
   }
-  if (IS_STRING(x)) return %StringEquals(x, y);
-  if (IS_BOOLEAN(x)) return y == x;
-
-  return %_ObjectEquals(x, y);
+  return x === y
 }
 
 

diff --git a/test/mjsunit/samevalue.js b/test/mjsunit/samevalue.js
new file mode 100644 (file)
index 0000000..2de677e
--- /dev/null
+++ b/test/mjsunit/samevalue.js
@@ -0,0 +1,102 @@
+// Copyright 2010 the V8 project authors. All rights reserved.\r
+// Redistribution and use in source and binary forms, with or without\r
+// modification, are permitted provided that the following conditions are\r
+// met:\r
+//\r
+//     * Redistributions of source code must retain the above copyright\r
+//       notice, this list of conditions and the following disclaimer.\r
+//     * Redistributions in binary form must reproduce the above\r
+//       copyright notice, this list of conditions and the following\r
+//       disclaimer in the documentation and/or other materials provided\r
+//       with the distribution.\r
+//     * Neither the name of Google Inc. nor the names of its\r
+//       contributors may be used to endorse or promote products derived\r
+//       from this software without specific prior written permission.\r
+//\r
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\r
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\r
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\r
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\r
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\r
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\r
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\r
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\r
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\r
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\r
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\r
+\r
+\r
+// Flags: --expose-natives_as natives\r
+// Test the SameValue internal method.\r
+\r
+var obj1 = {x: 10, y: 11, z: "test"};\r
+var obj2 = {x: 10, y: 11, z: "test"};\r
+\r
+assertTrue(natives.SameValue(0, 0));\r
+assertTrue(natives.SameValue(+0, +0));\r
+assertTrue(natives.SameValue(-0, -0));\r
+assertTrue(natives.SameValue(1, 1));\r
+assertTrue(natives.SameValue(2, 2));\r
+assertTrue(natives.SameValue(-1, -1));\r
+assertTrue(natives.SameValue(0.5, 0.5));\r
+assertTrue(natives.SameValue(true, true));\r
+assertTrue(natives.SameValue(false, false));\r
+assertTrue(natives.SameValue(NaN, NaN));\r
+assertTrue(natives.SameValue(null, null));\r
+assertTrue(natives.SameValue("foo", "foo"));\r
+assertTrue(natives.SameValue(obj1, obj1));\r
+// Undefined values.\r
+assertTrue(natives.SameValue());\r
+assertTrue(natives.SameValue(undefined, undefined));\r
+\r
+assertFalse(natives.SameValue(0,1));\r
+assertFalse(natives.SameValue("foo", "bar"));\r
+assertFalse(natives.SameValue(obj1, obj2));\r
+assertFalse(natives.SameValue(true, false));\r
+\r
+assertFalse(natives.SameValue(obj1, true));\r
+assertFalse(natives.SameValue(obj1, "foo"));\r
+assertFalse(natives.SameValue(obj1, 1));\r
+assertFalse(natives.SameValue(obj1, undefined));\r
+assertFalse(natives.SameValue(obj1, NaN));\r
+\r
+assertFalse(natives.SameValue(undefined, true));\r
+assertFalse(natives.SameValue(undefined, "foo"));\r
+assertFalse(natives.SameValue(undefined, 1));\r
+assertFalse(natives.SameValue(undefined, obj1));\r
+assertFalse(natives.SameValue(undefined, NaN));\r
+\r
+assertFalse(natives.SameValue(NaN, true));\r
+assertFalse(natives.SameValue(NaN, "foo"));\r
+assertFalse(natives.SameValue(NaN, 1));\r
+assertFalse(natives.SameValue(NaN, obj1));\r
+assertFalse(natives.SameValue(NaN, undefined));\r
+\r
+assertFalse(natives.SameValue("foo", true));\r
+assertFalse(natives.SameValue("foo", 1));\r
+assertFalse(natives.SameValue("foo", obj1));\r
+assertFalse(natives.SameValue("foo", undefined));\r
+assertFalse(natives.SameValue("foo", NaN));\r
+\r
+assertFalse(natives.SameValue(true, 1));\r
+assertFalse(natives.SameValue(true, obj1));\r
+assertFalse(natives.SameValue(true, undefined));\r
+assertFalse(natives.SameValue(true, NaN));\r
+assertFalse(natives.SameValue(true, "foo"));\r
+\r
+assertFalse(natives.SameValue(1, true));\r
+assertFalse(natives.SameValue(1, obj1));\r
+assertFalse(natives.SameValue(1, undefined));\r
+assertFalse(natives.SameValue(1, NaN));\r
+assertFalse(natives.SameValue(1, "foo"));\r
+\r
+// Special string cases.\r
+assertFalse(natives.SameValue("1", 1));\r
+assertFalse(natives.SameValue("true", true));\r
+assertFalse(natives.SameValue("false", false));\r
+assertFalse(natives.SameValue("undefined", undefined));\r
+assertFalse(natives.SameValue("NaN", NaN));\r
+\r
+// -0 and +0 are should be different\r
+assertFalse(natives.SameValue(+0, -0));\r
+assertFalse(natives.SameValue(-0, +0));\r