Fix logic in nla_read_ts_credentials
authorDavid Fort <contact@hardening-consulting.com>
Mon, 13 Nov 2017 14:50:28 +0000 (15:50 +0100)
committerArmin Novak <armin.novak@thincast.com>
Mon, 13 Nov 2017 15:20:57 +0000 (16:20 +0100)
libfreerdp/core/nla.c

index e945c74..ac1c4cc 100644 (file)
@@ -1316,9 +1316,9 @@ static BOOL nla_read_ts_credentials(rdpNla* nla, PSecBuffer ts_credentials)
        ret = ber_read_sequence_tag(s, &length) &&
              /* [0] credType (INTEGER) */
              ber_read_contextual_tag(s, 0, &length, TRUE) &&
-             ber_read_integer(s, NULL);
-       /* [1] credentials (OCTET STRING) */
-       ret += ber_read_contextual_tag(s, 1, &length, TRUE) &&
+             ber_read_integer(s, NULL) &&
+             /* [1] credentials (OCTET STRING) */
+             ber_read_contextual_tag(s, 1, &length, TRUE) &&
              ber_read_octet_string_tag(s, &ts_password_creds_length) &&
              nla_read_ts_password_creds(nla, s);
        Stream_Free(s, FALSE);