iio: dac: ltc1660: Make use of the helper function dev_err_probe()
authorCai Huoqing <caihuoqing@baidu.com>
Tue, 28 Sep 2021 01:38:56 +0000 (09:38 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 19 Oct 2021 07:30:43 +0000 (08:30 +0100)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Link: https://lore.kernel.org/r/20210928013902.1341-3-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ltc1660.c

index dc10188540cad3dd87f3366ff3e4023c32780396..f6ec9bf5815ea7af30dee677afb0fe9818eaf9db 100644 (file)
@@ -172,10 +172,9 @@ static int ltc1660_probe(struct spi_device *spi)
        }
 
        priv->vref_reg = devm_regulator_get(&spi->dev, "vref");
-       if (IS_ERR(priv->vref_reg)) {
-               dev_err(&spi->dev, "vref regulator not specified\n");
-               return PTR_ERR(priv->vref_reg);
-       }
+       if (IS_ERR(priv->vref_reg))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->vref_reg),
+                                    "vref regulator not specified\n");
 
        ret = regulator_enable(priv->vref_reg);
        if (ret) {