dtlsconnection: Replace if-else chain with switch
authorJan Alexander Steffens (heftig) <jsteffens@make.tv>
Mon, 5 Nov 2018 11:37:21 +0000 (12:37 +0100)
committerSebastian Dröge <slomo@coaxion.net>
Tue, 6 Nov 2018 16:23:50 +0000 (16:23 +0000)
A more idiomatic construct for testing a bunch of integers.

ext/dtls/gstdtlsconnection.c

index 0242aeb..a6db163 100644 (file)
@@ -721,23 +721,24 @@ openssl_poll (GstDtlsConnection * self)
 
   log_state (self, "poll: after handshake");
 
-  if (ret == 1) {
-    if (!self->priv->keys_exported) {
-      GST_INFO_OBJECT (self,
-          "handshake just completed successfully, exporting keys");
-      export_srtp_keys (self);
-    } else {
-      GST_INFO_OBJECT (self, "handshake is completed");
-    }
-    return;
-  } else {
-    if (ret == 0) {
+  switch (ret) {
+    case 1:
+      if (!self->priv->keys_exported) {
+        GST_INFO_OBJECT (self,
+            "handshake just completed successfully, exporting keys");
+        export_srtp_keys (self);
+      } else {
+        GST_INFO_OBJECT (self, "handshake is completed");
+      }
+      return;
+    case 0:
       GST_DEBUG_OBJECT (self, "do_handshake encountered EOF");
-    } else if (ret == -1) {
+      break;
+    case -1:
       GST_DEBUG_OBJECT (self, "do_handshake encountered BIO error");
-    } else {
+      break;
+    default:
       GST_DEBUG_OBJECT (self, "do_handshake returned %d", ret);
-    }
   }
 
   error = SSL_get_error (self->priv->ssl, ret);