ASoC: Intel: bytcht_cx2072x: Replace open coded acpi_dev_put()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 2 Jan 2023 20:30:33 +0000 (22:30 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 5 Jan 2023 11:15:27 +0000 (11:15 +0000)
Instead of calling put_device(&adev->dev) where adev is a pointer
to an ACPI device, use specific call, i.e. acpi_dev_put().

Also move it out of the conditional to make it more visible in case
some other code will be added which may use that pointer. We need
to keep a reference as long as we use the pointer.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230102203037.16120-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcht_cx2072x.c

index 41cec67..9942a2d 100644 (file)
@@ -253,9 +253,9 @@ static int snd_byt_cht_cx2072x_probe(struct platform_device *pdev)
        if (adev) {
                snprintf(codec_name, sizeof(codec_name), "i2c-%s",
                         acpi_dev_name(adev));
-               put_device(&adev->dev);
                byt_cht_cx2072x_dais[dai_index].codecs->name = codec_name;
        }
+       acpi_dev_put(adev);
 
        /* override platform name, if required */
        ret = snd_soc_fixup_dai_links_platform_name(&byt_cht_cx2072x_card,