init: fix error check in clean_path()
authorBarret Rhoden <brho@google.com>
Fri, 4 Sep 2020 13:53:32 +0000 (09:53 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 4 Sep 2020 16:16:58 +0000 (09:16 -0700)
init_stat() returns 0 on success, same as vfs_lstat().  When it replaced
vfs_lstat(), the '!' was dropped.

Fixes: 716308a5331b ("init: add an init_stat helper")
Signed-off-by: Barret Rhoden <brho@google.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
init/initramfs.c

index e6dbfb767057df7531fc6528899ec854d6bc77a2..1f97c0328a7ae7b7eaedb2ab0daa4d4e2c29354f 100644 (file)
@@ -297,7 +297,7 @@ static void __init clean_path(char *path, umode_t fmode)
 {
        struct kstat st;
 
-       if (init_stat(path, &st, AT_SYMLINK_NOFOLLOW) &&
+       if (!init_stat(path, &st, AT_SYMLINK_NOFOLLOW) &&
            (st.mode ^ fmode) & S_IFMT) {
                if (S_ISDIR(st.mode))
                        init_rmdir(path);