projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5f2779d
)
blk-iocost: check return value of match_u64()
author
Yu Kuai
<yukuai3@huawei.com>
Tue, 17 Jan 2023 07:08:02 +0000
(15:08 +0800)
committer
Jens Axboe
<axboe@kernel.dk>
Sun, 29 Jan 2023 22:18:34 +0000
(15:18 -0700)
This patch fixs that the return value of match_u64() from ioc_qos_write()
is not checked,
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link:
https://lore.kernel.org/r/20230117070806.3857142-2-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c
patch
|
blob
|
history
diff --git
a/block/blk-iocost.c
b/block/blk-iocost.c
index b691b6bb498f30180edb69b3c39b446428872886..3b99c6a7a104cac8e541ff7e3bcfdf55e0593e80 100644
(file)
--- a/
block/blk-iocost.c
+++ b/
block/blk-iocost.c
@@
-3214,7
+3214,8
@@
static ssize_t ioc_qos_write(struct kernfs_open_file *of, char *input,
switch (match_token(p, qos_ctrl_tokens, args)) {
case QOS_ENABLE:
- match_u64(&args[0], &v);
+ if (match_u64(&args[0], &v))
+ goto einval;
enable = v;
continue;
case QOS_CTRL: