media: uvcvideo: Fix assignment inside if condition
authorPedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br>
Tue, 25 Oct 2022 05:04:49 +0000 (02:04 -0300)
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Sun, 15 Jan 2023 21:45:09 +0000 (23:45 +0200)
Fixes 'do not use assignment in if condition' errors issued by
scripts/checkpatch.pl on drivers/media/usb/uvc/uvc_driver.c

Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/media/usb/uvc/uvc_driver.c

index 8f649fa..d84e46f 100644 (file)
@@ -1144,7 +1144,8 @@ static int uvc_parse_control(struct uvc_device *dev)
                    buffer[1] != USB_DT_CS_INTERFACE)
                        goto next_descriptor;
 
-               if ((ret = uvc_parse_standard_control(dev, buffer, buflen)) < 0)
+               ret = uvc_parse_standard_control(dev, buffer, buflen);
+               if (ret < 0)
                        return ret;
 
 next_descriptor:
@@ -2180,7 +2181,8 @@ static int uvc_probe(struct usb_interface *intf,
        usb_set_intfdata(intf, dev);
 
        /* Initialize the interrupt URB. */
-       if ((ret = uvc_status_init(dev)) < 0) {
+       ret = uvc_status_init(dev);
+       if (ret < 0) {
                dev_info(&dev->udev->dev,
                         "Unable to initialize the status endpoint (%d), status interrupt will not be supported.\n",
                         ret);