ASoC: codecs: Fix runtime PM imbalance in tas2552_probe
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Thu, 8 Apr 2021 06:40:34 +0000 (14:40 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 8 Apr 2021 14:08:50 +0000 (15:08 +0100)
There is a rumtime PM imbalance between the error handling path
after devm_snd_soc_register_component() and all other error
handling paths. Add a PM runtime increment to balance refcount.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20210408064036.6691-1-dinghao.liu@zju.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2552.c

index bd00c35..700baa6 100644 (file)
@@ -730,8 +730,10 @@ static int tas2552_probe(struct i2c_client *client,
        ret = devm_snd_soc_register_component(&client->dev,
                                      &soc_component_dev_tas2552,
                                      tas2552_dai, ARRAY_SIZE(tas2552_dai));
-       if (ret < 0)
+       if (ret < 0) {
                dev_err(&client->dev, "Failed to register component: %d\n", ret);
+               pm_runtime_get_noresume(&client->dev);
+       }
 
        return ret;
 }