media: lirc: no need to recalculate duration
authorSean Young <sean@mess.org>
Wed, 13 Dec 2017 21:17:44 +0000 (16:17 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 18 Dec 2017 20:21:49 +0000 (15:21 -0500)
This is code existed for when drivers would send less than the whole
buffer; no driver does this any more, so this is redundant. Drivers
should return -EINVAL if they cannot send the entire buffer.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/rc/lirc_dev.c

index 8618aba..1fc1fd6 100644 (file)
@@ -347,15 +347,6 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, const char __user *buf,
        if (ret < 0)
                goto out_kfree;
 
-       if (fh->send_mode == LIRC_MODE_SCANCODE) {
-               ret = n;
-       } else {
-               for (duration = i = 0; i < ret; i++)
-                       duration += txbuf[i];
-
-               ret *= sizeof(unsigned int);
-       }
-
        /*
         * The lircd gap calculation expects the write function to
         * wait for the actual IR signal to be transmitted before
@@ -368,6 +359,7 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, const char __user *buf,
                schedule_timeout(usecs_to_jiffies(towait));
        }
 
+       ret = n;
 out_kfree:
        kfree(txbuf);
        kfree(raw);