net/mlx5e: Fix a use after free on error in mlx5_tc_ct_shared_counter_get()

This code frees "shared_counter" and then dereferences on the next line
to get the error code.

Fixes: 1edae2335adf ("net/mlx5e: CT: Use the same counter for both directions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index b5f8ed3..cea2070 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -739,6 +739,7 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
        struct mlx5_core_dev *dev = ct_priv->dev;
        struct mlx5_ct_entry *rev_entry;
        __be16 tmp_port;
+       int ret;
 
        /* get the reversed tuple */
        tmp_port = rev_tuple.port.src;
@@ -778,8 +779,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
        shared_counter->counter = mlx5_fc_create(dev, true);
        if (IS_ERR(shared_counter->counter)) {
                ct_dbg("Failed to create counter for ct entry");
+               ret = PTR_ERR(shared_counter->counter);
                kfree(shared_counter);
-               return ERR_PTR(PTR_ERR(shared_counter->counter));
+               return ERR_PTR(ret);
        }
 
        refcount_set(&shared_counter->refcount, 1);