drm/i915/display: remove duplicated assignment to pointer crtc_state
authorColin Ian King <colin.king@canonical.com>
Tue, 10 Dec 2019 14:45:35 +0000 (14:45 +0000)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 11 Dec 2019 16:18:54 +0000 (18:18 +0200)
Pointer crtc_state is being assigned twice, one of these is redundant
and can be removed.

Addresses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191210144535.341977-1-colin.king@canonical.com
drivers/gpu/drm/i915/display/intel_display.c

index d0d37a9..0e5a339 100644 (file)
@@ -17751,7 +17751,7 @@ intel_modeset_setup_hw_state(struct drm_device *dev,
 
        for_each_intel_crtc(&dev_priv->drm, crtc) {
                struct intel_crtc_state *crtc_state =
-                       crtc_state = to_intel_crtc_state(crtc->base.state);
+                       to_intel_crtc_state(crtc->base.state);
 
                intel_sanitize_crtc(crtc, ctx);
                intel_dump_pipe_config(crtc_state, NULL, "[setup_hw_state]");