ALSA: ca0106: Simplify with snd_ctl_find_id_mixer()
authorTakashi Iwai <tiwai@suse.de>
Thu, 20 Jul 2023 08:20:59 +0000 (10:20 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 21 Jul 2023 07:10:39 +0000 (09:10 +0200)
Replace an open code with the new snd_ctl_find_id_mixer().
There is no functional change.

Link: https://lore.kernel.org/r/20230720082108.31346-3-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ca0106/ca0106_mixer.c

index f6381c0..2f37d2c 100644 (file)
@@ -706,19 +706,9 @@ static int remove_ctl(struct snd_card *card, const char *name)
        return snd_ctl_remove_id(card, &id);
 }
 
-static struct snd_kcontrol *ctl_find(struct snd_card *card, const char *name)
-{
-       struct snd_ctl_elem_id sid;
-       memset(&sid, 0, sizeof(sid));
-       /* FIXME: strcpy is bad. */
-       strcpy(sid.name, name);
-       sid.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
-       return snd_ctl_find_id(card, &sid);
-}
-
 static int rename_ctl(struct snd_card *card, const char *src, const char *dst)
 {
-       struct snd_kcontrol *kctl = ctl_find(card, src);
+       struct snd_kcontrol *kctl = snd_ctl_find_id_mixer(card, src);
        if (kctl) {
                snd_ctl_rename(card, kctl, dst);
                return 0;
@@ -765,7 +755,8 @@ static void add_followers(struct snd_card *card,
                          struct snd_kcontrol *master, const char * const *list)
 {
        for (; *list; list++) {
-               struct snd_kcontrol *follower = ctl_find(card, *list);
+               struct snd_kcontrol *follower =
+                       snd_ctl_find_id_mixer(card, *list);
                if (follower)
                        snd_ctl_add_follower(master, follower);
        }