cdrom: remove the unused mode argument to cdrom_release
authorChristoph Hellwig <hch@lst.de>
Thu, 8 Jun 2023 11:02:34 +0000 (13:02 +0200)
committerJens Axboe <axboe@kernel.dk>
Mon, 12 Jun 2023 14:04:03 +0000 (08:04 -0600)
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Acked-by: Christian Brauner <brauner@kernel.org>
Link: https://lore.kernel.org/r/20230608110258.189493-7-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/cdrom/cdrom.c
drivers/cdrom/gdrom.c
drivers/scsi/sr.c
include/linux/cdrom.h

index adebac1..998b03f 100644 (file)
@@ -1250,7 +1250,7 @@ static int check_for_audio_disc(struct cdrom_device_info *cdi,
        return 0;
 }
 
-void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode)
+void cdrom_release(struct cdrom_device_info *cdi)
 {
        const struct cdrom_device_ops *cdo = cdi->ops;
 
index 1492240..a401dc4 100644 (file)
@@ -481,7 +481,7 @@ static int gdrom_bdops_open(struct block_device *bdev, fmode_t mode)
        bdev_check_media_change(bdev);
 
        mutex_lock(&gdrom_mutex);
-       ret = cdrom_open(gd.cd_info, mode);
+       ret = cdrom_open(gd.cd_info);
        mutex_unlock(&gdrom_mutex);
        return ret;
 }
index 444c7ef..6d33120 100644 (file)
@@ -512,7 +512,7 @@ static void sr_block_release(struct gendisk *disk, fmode_t mode)
        struct scsi_cd *cd = scsi_cd(disk);
 
        mutex_lock(&cd->lock);
-       cdrom_release(&cd->cdi, mode);
+       cdrom_release(&cd->cdi);
        mutex_unlock(&cd->lock);
 
        scsi_device_put(cd->device);
index adcc9f2..3c253b2 100644 (file)
@@ -102,7 +102,7 @@ int cdrom_read_tocentry(struct cdrom_device_info *cdi,
 
 /* the general block_device operations structure: */
 int cdrom_open(struct cdrom_device_info *cdi, fmode_t mode);
-extern void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode);
+void cdrom_release(struct cdrom_device_info *cdi);
 int cdrom_ioctl(struct cdrom_device_info *cdi, struct block_device *bdev,
                unsigned int cmd, unsigned long arg);
 extern unsigned int cdrom_check_events(struct cdrom_device_info *cdi,