cifsd: Remove is_attributes_write_allowed() wrapper
authorMarios Makassikis <mmakassikis@freebox.fr>
Tue, 27 Apr 2021 06:30:22 +0000 (15:30 +0900)
committerSteve French <stfrench@microsoft.com>
Tue, 11 May 2021 00:15:45 +0000 (19:15 -0500)
Inline it in the only place it is used and remove it.

Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifsd/smb2pdu.c

index 73c6154..eeb3f09 100644 (file)
@@ -5237,11 +5237,6 @@ out:
        return rc;
 }
 
-static bool is_attributes_write_allowed(struct ksmbd_file *fp)
-{
-       return fp->daccess & FILE_WRITE_ATTRIBUTES_LE;
-}
-
 static int set_file_basic_info(struct ksmbd_file *fp, char *buf,
                struct ksmbd_share_config *share)
 {
@@ -5252,7 +5247,7 @@ static int set_file_basic_info(struct ksmbd_file *fp, char *buf,
        struct inode *inode;
        int rc;
 
-       if (!is_attributes_write_allowed(fp))
+       if (!(fp->daccess & FILE_WRITE_ATTRIBUTES_LE))
                return -EACCES;
 
        file_info = (struct smb2_file_all_info *)buf;