projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c3e1bf6
)
RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode
author
Bryan Tan
<bryantan@vmware.com>
Mon, 5 Jun 2023 18:37:28 +0000
(11:37 -0700)
committer
Jason Gunthorpe
<jgg@nvidia.com>
Fri, 9 Jun 2023 17:11:53 +0000
(14:11 -0300)
wr->opcode is unsigned; checking if it is negative is unnecessary. Fix
this issue by removing the check.
Fixes:
29c8d9eba550
("IB: Add vmw_pvrdma driver")
Link:
https://lore.kernel.org/r/20230605183728.47021-1-bryantan@vmware.com
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/
07c48eee
-0aca-48ee-897a-
38588c341c41
@kili.mountain
Signed-off-by: Bryan Tan <bryantan@vmware.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
patch
|
blob
|
history
diff --git
a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
index
f83cd4a
..
98b2a00
100644
(file)
--- a/
drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
+++ b/
drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
@@
-709,14
+709,6
@@
int pvrdma_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr,
goto out;
}
- if (unlikely(wr->opcode < 0)) {
- dev_warn_ratelimited(&dev->pdev->dev,
- "invalid send opcode\n");
- *bad_wr = wr;
- ret = -EINVAL;
- goto out;
- }
-
/*
* Only support UD, RC.
* Need to check opcode table for thorough checking.