[libcxx] [test] Don't add dirs from the LIB env var to PATH
authorMartin Storsjö <martin@martin.st>
Wed, 24 Mar 2021 07:31:54 +0000 (09:31 +0200)
committerMartin Storsjö <martin@martin.st>
Wed, 31 Mar 2021 06:05:47 +0000 (09:05 +0300)
The directories in LIB normally only contain import libraries or
static libraries, no runtime DLLs that would need to be found
while running tests.

This code stems from 1cd196e7b46e49d170a4b4013879a577dee59cb2,
which (among other things) tried to do this:

> * [Test] Fix handling of library runtime search paths by correctly adding them
>   to the PATH variable when running the tests.

It's unclear to me exactly what this fixed (or tried to) at the time,
as the LIB var doesn't normally point to runtime libs.

Differential Revision: https://reviews.llvm.org/D99241

libcxx/utils/libcxx/test/config.py

index 88527a4..11ebb91 100644 (file)
@@ -209,8 +209,6 @@ class Configuration(object):
         flags = []
         compile_flags = []
         link_flags = _prefixed_env_list('LIB', '-L')
-        for path in _split_env_var('LIB'):
-            self.add_path(self.exec_env, path)
         return CXXCompiler(self, clang_path, flags=flags,
                            compile_flags=compile_flags,
                            link_flags=link_flags)