os: Make sure that writing our pid to the lock file actually worked
authorKeith Packard <keithp@keithp.com>
Fri, 18 Apr 2014 22:05:00 +0000 (15:05 -0700)
committerKeith Packard <keithp@keithp.com>
Fri, 18 Apr 2014 23:30:17 +0000 (16:30 -0700)
There's no sense verifying that we can create the lock file and then
ignoring the return value from write.

Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
os/utils.c

index 6e6974e..83d85cd 100644 (file)
@@ -313,7 +313,8 @@ LockServer(void)
     if (lfd < 0)
         FatalError("Could not create lock file in %s\n", tmp);
     snprintf(pid_str, sizeof(pid_str), "%10ld\n", (long) getpid());
-    (void) write(lfd, pid_str, 11);
+    if (write(lfd, pid_str, 11) != 11)
+        FatalError("Could not write pid to lock file in %s\n", tmp);
     (void) fchmod(lfd, 0444);
     (void) close(lfd);