scsi: mpt3sas: Fix ioc->base_readl() use

The functions _base_readl_aero() and _base_readl() used for an adapter
base_readl() method are implemented using a regular readl() call which
internally performs a conversion to CPU endianness (le32_to_cpu()) of
the values read. The users of the ioc base_readl() method should thus
not convert again the values read using le16_to_cpu().
Fixing this removes sparse warnings.

Link: https://lore.kernel.org/r/20220307234854.148145-4-damien.lemoal@opensource.wdc.com
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index d7b23eb9b630cf0e4d303a5cb38d90a40d40afc5..baacba436fce3b3869f197f64a10874fcf7ee5c2 100644 (file)
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -6912,16 +6912,16 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes,
        }
 
        /* read the first two 16-bits, it gives the total length of the reply */
-       reply[0] = le16_to_cpu(ioc->base_readl(&ioc->chip->Doorbell)
-           & MPI2_DOORBELL_DATA_MASK);
+       reply[0] = ioc->base_readl(&ioc->chip->Doorbell)
+               & MPI2_DOORBELL_DATA_MASK;
        writel(0, &ioc->chip->HostInterruptStatus);
        if ((_base_wait_for_doorbell_int(ioc, 5))) {
                ioc_err(ioc, "doorbell handshake int failed (line=%d)\n",
                        __LINE__);
                return -EFAULT;
        }
-       reply[1] = le16_to_cpu(ioc->base_readl(&ioc->chip->Doorbell)
-           & MPI2_DOORBELL_DATA_MASK);
+       reply[1] = ioc->base_readl(&ioc->chip->Doorbell)
+               & MPI2_DOORBELL_DATA_MASK;
        writel(0, &ioc->chip->HostInterruptStatus);
 
        for (i = 2; i < default_reply->MsgLength * 2; i++)  {
@@ -6933,9 +6933,8 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes,
                if (i >=  reply_bytes/2) /* overflow case */
                        ioc->base_readl(&ioc->chip->Doorbell);
                else
-                       reply[i] = le16_to_cpu(
-                           ioc->base_readl(&ioc->chip->Doorbell)
-                           & MPI2_DOORBELL_DATA_MASK);
+                       reply[i] = ioc->base_readl(&ioc->chip->Doorbell)
+                               & MPI2_DOORBELL_DATA_MASK;
                writel(0, &ioc->chip->HostInterruptStatus);
        }