tps6598x: clear int mask on probe failure

commit aba2081e0a9c977396124aa6df93b55ed5912b19 upstream.

The interrupt mask is enabled before any potential failure points in
the driver, which can leave a failure path where we exit with
interrupts enabled but the device not live. This causes an infinite
stream of interrupts on an Apple M1 Pro laptop on USB-C.

Add a failure label that's used post enabling interrupts, where we
mask them again before returning an error.

Suggested-by: Sven Peter <sven@svenpeter.dev>
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Link: https://lore.kernel.org/r/e6b80669-20f3-06e7-9ed5-8951a9c6db6f@kernel.dk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 97f50f3..d229d2d 100644 (file)
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -618,12 +618,12 @@ static int tps6598x_probe(struct i2c_client *client)
 
        ret = tps6598x_read32(tps, TPS_REG_STATUS, &status);
        if (ret < 0)
-               return ret;
+               goto err_clear_mask;
        trace_tps6598x_status(status);
 
        ret = tps6598x_read32(tps, TPS_REG_SYSTEM_CONF, &conf);
        if (ret < 0)
-               return ret;
+               goto err_clear_mask;
 
        /*
         * This fwnode has a "compatible" property, but is never populated as a
@@ -712,7 +712,8 @@ err_role_put:
        usb_role_switch_put(tps->role_sw);
 err_fwnode_put:
        fwnode_handle_put(fwnode);
-
+err_clear_mask:
+       tps6598x_write64(tps, TPS_REG_INT_MASK1, 0);
        return ret;
 }