QGraphicsView - remove reference to avoid weird code.
authorThorbjørn Lund Martsum <tmartsum@gmail.com>
Tue, 11 Dec 2012 05:42:28 +0000 (06:42 +0100)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Tue, 11 Dec 2012 12:37:57 +0000 (13:37 +0100)
Even though the code before theoretic is ok, we really shouldn't
have a reference since mapFromScene returns a QPointF and not a
const QPointF&.

Change-Id: I5ea8fd238bdbdd21fb1e3b6b5f280d45e3bc43ef
Reviewed-by: Andy Shaw <andy.shaw@digia.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
src/widgets/graphicsview/qgraphicsview.cpp

index 2012f98..411297e 100644 (file)
@@ -3238,7 +3238,7 @@ void QGraphicsView::mouseMoveEvent(QMouseEvent *event)
             }
 
             // Update rubberband position
-            const QPoint &mp = mapFromScene(d->mousePressScenePoint);
+            const QPoint mp = mapFromScene(d->mousePressScenePoint);
             QPoint ep = event->pos();
             d->rubberBandRect = QRect(qMin(mp.x(), ep.x()), qMin(mp.y(), ep.y()),
                                       qAbs(mp.x() - ep.x()) + 1, qAbs(mp.y() - ep.y()) + 1);