module: Fix NULL vs IS_ERR checking for module_get_next_page

[ Upstream commit 45af1d7aae7d5520d2858f8517a1342646f015db ]

The module_get_next_page() function return error pointers on error
instead of NULL.
Use IS_ERR() to check the return value to fix this.

Fixes: b1ae6dc41eaa ("module: add in-kernel support for decompressing")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/kernel/module/decompress.c b/kernel/module/decompress.c
index c033572d83f0e889d997f66a7269af69a936ec61..720e719253cd149fcf70096709ff40b3d5b139fa 100644 (file)
--- a/kernel/module/decompress.c
+++ b/kernel/module/decompress.c
@@ -114,8 +114,8 @@ static ssize_t module_gzip_decompress(struct load_info *info,
        do {
                struct page *page = module_get_next_page(info);
 
-               if (!page) {
-                       retval = -ENOMEM;
+               if (IS_ERR(page)) {
+                       retval = PTR_ERR(page);
                        goto out_inflate_end;
                }
 
@@ -173,8 +173,8 @@ static ssize_t module_xz_decompress(struct load_info *info,
        do {
                struct page *page = module_get_next_page(info);
 
-               if (!page) {
-                       retval = -ENOMEM;
+               if (IS_ERR(page)) {
+                       retval = PTR_ERR(page);
                        goto out;
                }