dyndbg: vpr-info on remove-module complete, not starting
authorJim Cromie <jim.cromie@gmail.com>
Wed, 13 Oct 2021 22:07:25 +0000 (16:07 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Oct 2021 08:59:10 +0000 (10:59 +0200)
On qemu --smp 3 runs, remove-module can get called 3 times.
So don't print on entry; instead print "removed" after entry is
found and removed, so just once.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Link: https://lore.kernel.org/r/20211013220726.1280565-3-jim.cromie@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/dynamic_debug.c

index a44ae0b..d706abb 100644 (file)
@@ -1025,8 +1025,6 @@ int ddebug_remove_module(const char *mod_name)
        struct ddebug_table *dt, *nextdt;
        int ret = -ENOENT;
 
-       v2pr_info("removing module \"%s\"\n", mod_name);
-
        mutex_lock(&ddebug_lock);
        list_for_each_entry_safe(dt, nextdt, &ddebug_tables, link) {
                if (dt->mod_name == mod_name) {
@@ -1036,6 +1034,8 @@ int ddebug_remove_module(const char *mod_name)
                }
        }
        mutex_unlock(&ddebug_lock);
+       if (!ret)
+               v2pr_info("removed module \"%s\"\n", mod_name);
        return ret;
 }