mm/highmem: remove unnecessary done label
authorMiaohe Lin <linmiaohe@huawei.com>
Tue, 22 Mar 2022 21:48:01 +0000 (14:48 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 22 Mar 2022 22:57:11 +0000 (15:57 -0700)
Remove unnecessary done label to simplify the code.

Link: https://lkml.kernel.org/r/20220126092542.64659-1-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/highmem.c

index 7626790..0cc0c4d 100644 (file)
@@ -736,11 +736,11 @@ void *page_address(const struct page *page)
                list_for_each_entry(pam, &pas->lh, list) {
                        if (pam->page == page) {
                                ret = pam->virtual;
-                               goto done;
+                               break;
                        }
                }
        }
-done:
+
        spin_unlock_irqrestore(&pas->lock, flags);
        return ret;
 }
@@ -773,13 +773,12 @@ void set_page_address(struct page *page, void *virtual)
                list_for_each_entry(pam, &pas->lh, list) {
                        if (pam->page == page) {
                                list_del(&pam->list);
-                               spin_unlock_irqrestore(&pas->lock, flags);
-                               goto done;
+                               break;
                        }
                }
                spin_unlock_irqrestore(&pas->lock, flags);
        }
-done:
+
        return;
 }